Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove codecov #114

Merged
merged 1 commit into from
Apr 21, 2022
Merged

*: remove codecov #114

merged 1 commit into from
Apr 21, 2022

Conversation

vbatts
Copy link
Contributor

@vbatts vbatts commented Apr 20, 2022

Signed-off-by: Vincent Batts [email protected]

From the slack conversation, it seems this codecov report is not useful and not quite accurate. It fails to reference git commits, and lists files that do not exist. I think getting a trusted local make target is a better focus.

Signed-off-by: Vincent Batts <[email protected]>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzys
Copy link
Member

kzys commented Apr 21, 2022

I added codecov back in #105 but seems @dmcgowan was right :)

@kzys kzys merged commit 74421d1 into containerd:main Apr 21, 2022
@vbatts vbatts deleted the coverage branch April 28, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants